[Linux-fbdev-devel] Re: [linux-fbdev] [ANNOUNCE] fbgen "2"

[Petr V. <VAN...@vc...>]

On 28 Jun 01 at 16:53, James Simmons wrote:

> To:             FrameBuffer List <lin...@vu...>
                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Can somebody tell me which one is current developer list? Or do we have
two?
                  
> Subject:        [linux-fbdev] [ANNOUNCE] fbgen "2"

> @@ -306,12 +313,16 @@
>     struct fb_monspecs monspecs;         /* Current Monitor specs */
>     struct fb_cmap cmap;                 /* Current cmap */
>     struct fb_ops *fbops;
> +#ifdef CONFIG_PM
> +   struct pm_dev *pm_fb;   
> +#endif   
>     char *screen_base;                   /* Virtual address */
>     struct display *disp;       /* initial display variable */

I have two problems with this: 
(1) Please remove ifdef CONFIG_PM around that. pm.h provides dummy
    pm_* functions when pm is disabled, so you do not have to check
    CONFIG_PM in driver sources. But if structure does not have this
    pm_fb field, you must :-(
(2) Is there any reason for having this pointer in this structure at
    all? Does anybody except driver itself need such thing? You can 
    have couple of fbdevs pointing to one pm_dev, just because of 
    they live on same device and cannot be powered up independently.
                                        Thanks,
                                                Petr Vandrovec
                                                van...@vc...