Re: [Linux-fbdev-devel] [PATCH] aty128fb 15/16 bit cleanup

[Michel <mic...@ii...>]

Petr Vandrovec wrote:
> 
> On 22 Jun 01 at 13:11, Geert Uytterhoeven wrote:
> >
> >     aty_st_dac(regno << 2, palette[regno/2].red, green,
> >                palette[regno/2].blue);
> >     aty_st_dac(regno << 3, red, palette[(2*regno) & 0xff].green, blue);
> 
> I do not see rest of code, but does your code correctly set
> zero register? Is not green field overwritten by its old value?

If the order is wrong, it can be changed.

> Can you try 'echo "^[]P0FFFFFF"' and switch to some other console and back?
> If you still see white background, OK. If you see something else (such as
> magentha background)...

That doesn't do anything but print the string for me?


> BTW, I think that you should use truecolor instead. It is much easier,
> and truecolor can cooperate with fbtv, while directcolor has bad troubles
> due to strange system which truecolor uses for painting characters.

I assume you mean directcolor. I don't think it's worth sacrifying directcolor
just because it's more complicated. XFree86 shows how to use it for gamma
correction, fbcon shows how to use it to simulate pseudocolor. You can't have
either with truecolor.

> Been there, done that, and hardwired palette registers to 1:1 in matroxfb...

How?


PS: Everything works now, cooking up a new patch. :)

-- 
Earthling Michel Dänzer (MrCooper)    \   Debian GNU/Linux (powerpc) developer
CS student, Free Software enthusiast   \        XFree86 and DRI project member