Re: [Linux-fbdev-devel] Two bugs in fbcon_putcs

[Geert U. <ge...@li...>]

On Sat, 16 Jun 2001, Martin Erhardsen wrote:
> I have a couple of further API questions.
> 
> How about reading 3 bytes past the end of the bitmap.
> I have noticed that 3dfx driver carefully avoids this,
> but if this were allowed, it would avoid having a special case for
> the last 3 bytes.

Which bitmap?

> Why not make the fbcon colormap 32 bits in 16 bpp modes too.
> This would use some extra bytes, but would avoid deciding
> between reading 16 or 32 bits from the colormap in putc and putcs.

Because it's not a real colormap but a map from console colors to pixel values?
(In theory we we would need it for bpp 8 etc. too). What with a card that has
pixels larger than 32 bit?

In 2.5.x you'll be able to do what you want, since the contents can be device
private, through your card's accel implementation.

Well, in fact you can use 32 bpp in your driver in 2.4.x as well, as long as
you no longer use _any_ fbcon-cfb* routines.

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@li...

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds