From: Geert U. <ge...@li...> - 2001-06-15 07:50:20
|
On Thu, 14 Jun 2001, James Simmons wrote: > > > NOTE: If this is the case then most drivers are broken!!!! > > > > Yep. Few (if any) drivers follow the rules 100%. > > So I have noticed :-( > > > If you can't change modes, the rule is still to round up, if possible. So if > > you try a mode where all parameters <= the only one supported mode, then you > > should return the only one supported mode. Else you should return -EINVAL. > > All the parameters? This makes for a meaty checking function. Yes, I've been thinking about providing a `staticfb' core for drivers that support one video mode only. Vesafb and offb (and a few of the PA-RISC drivers IIRC) can be build on top of that, with minimal additional code. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@li... In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds |