[Linux-fbdev-devel] Re: mode change policy

[Geert U. <ge...@li...>]

On Thu, 14 Jun 2001, James Simmons wrote:
>    Okay. I realize rounding up is also good for color depth changes.
> Someone could pass in a color depth of 12. We can easily fudge this to
> something that is supported. 
> 
> NOTE: If this is the case then most drivers are broken!!!!

Yep. Few (if any) drivers follow the rules 100%.

> They return a error instead. Also what is the policy for cards that can't
> change modes. Right now most drivers return a -EINVAL if they can't change
> a mode. Do we pass back the only mode the driver supports instead of
> returning a error? 

If you can't change modes, the rule is still to round up, if possible. So if
you try a mode where all parameters <= the only one supported mode, then you
should return the only one supported mode. Else you should return -EINVAL.

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@li...

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds