[Linux-fbdev-devel] Aty128fb as a module with options support

[Otto W. <ott...@bl...>]

As a non kernel and non kernel driver developer I tried to follow Petr
Vandrovec guidelines to change the aty128fb driver, that it supports
options if compiled as a module. I also looked at the matrox and the
riva drivers.

Since the driver compiled into the kernel (2.4.3, i386) only supports
options "noaccel" and "nomtrr" I tried to test these options first. But
it seems I'm not successful. While I'm not sure of the "noaccel" option
(no visible effect), even when specifying "nomtrr" the syslog showed
"aty128fb: Rage128 MTRR set to on".

Besides it seems I'm not to be able to figure out how to create a
correct diff, I tried "diff -U3 aty128fb.c.orig aty128fb.c" but this
doesn't produce a small diff. I'll give now a hand made diff, a correct
will follow later.

Removed all lines:
 #if[n]def MODULE

After MODULE_DESCRIPTION I added the following line:
 static const char *option __initdata = NULL;
 MODULE_PARM(noaccel, "i");
 MODULE_PARM_DESC(noaccel, "Disables hardware acceleration (0 or
1=disabled)  (default=0)");
 MODULE_PARM(fontname, "s");
 MODULE_PARM_DESC(fontname, "Specifies one of the compiled-in fonts
(max. 40chars, default=none)");
 #ifdef CONFIG_MTRR
 MODULE_PARM(mtrr, "i");
 MODULE_PARM_DESC(mtrr, "Disables MTRR support (0 or 1=disabled) (default=0)");
 #endif

After init_module(void) { I added the following line:
    aty128fb_setup(option);

Does anyone see what I'm doing wrong? Is there any way to reliable check
my change? How is a kernel driver debugged?

O. Wyss