[Linux-fbdev-devel] some questions about fbmem.c

[BERECZ S. <sz...@in...>]

Hi!

in fb_write() if one wants to write more than smem_len begining with the
0th byte it's ok. but if one writes e.g. beginning with the 1st byte at
least smem_len bytes, it gets ENOSPC.
is it supposed to do that?
so, for example I have a card with 16 bytes of mem :) :

loff_t ppos=0;
fb_write(foo, bar, 17, &ppos);
it returns 16

loff_t ppos=1;
fb_write(foo, bar, 16, &ppos);
it returns ENOSPC

I think it's at least confusing.

(sorry if it's not correct. I don't have a card supported by fbdev)

another "problem" in fb_read and fb_write
I think you should use this

if (count > fix.smem_len)

instead of this

if (count >= fix.smem_len)

it does not make sense, but it's cleaner.
(if there is no reason for using '>=')

Bye,
Szabi