Re: [Linux-fbdev-users] latest version of radeonfb

[Antonino A. D. <ad...@ho...>]

On Saturday 20 November 2004 00:01, Olaf Leidinger wrote:
> Hello!
>
> > Which kernel is this? My 2.6.10-rc1 kernel doesn't define the
> > radeon_noaccel_ops.. Or is it the old radeon driver?
> >
> > The new one is the one in aty/* .
>
> I know ... I modified radeon_base.c, which is part of the new driver.
>
> What I did was adding
>
>      if (noaccel)
>           {
>                 info->flags |= FBINFO_HWACCEL_DISABLED;
>                 info->fix.accel = FB_ACCEL_NONE;
>           }
>         else
>                 info->fix.accel = FB_ACCEL_ATI_RADEON;
>
> around line  1750 to make fbset and directfb believe hw accel is
> switched on.
>

Ok, that's a bug in radeon.  However the correct way is simply like this:

info->fix.accel = FB_ACCEL_ATI_RADEON;
if (noaccel)
	info->flags |= FBINFO_HWACCEL_DISABLED;

info->fix.accel is used as an identifier and should be enabled whether
console acceleration is disabled or not.  To disable userspace from
using the hardware, then either set:

1. info->fix.accel = FB_ACCEL_NONE; or
2. info->fix.mmio_len = 0;

Both of which will disable user space usage of the hardware.

Tony