Re: [Linux-fbdev-devel] [PATCH] s3c-fb: added patch series for s5pv210 and some features.

[Andrew M. <ak...@li...>]

On Fri, 7 May 2010 16:59:56 +0900 InKi Dae <da...@gm...> wrote:

> this includes three patch series and divides previous patch
> into smaller part.
> 
> so Andrew, please remove my previous patch,
> s3c-fb-add-s5pv210-support-and-some-features.patch from mm tree.
> 
> patch contents are as following.
> 
> 1. s3c_fb_1_3.patch
>   - as patch for supporting s5pv210, CH_ENABLE bit of SHAD
>     register should be enabled to enable window layer on s5pv210.
> 
> 2. s3c_fb_2_3.patch
>    - s5pv210 has five window layers (window0 ~ 4), among them,
>      window0 ~ 2 could be used for local path with fimc(capture device)
>      and fimd writeback feature so this patch makes default window
>      layer for UI to be set at machine code.
> 
> 3. s3c_fb_3_3.patch
>    - it has been working fine at 16bpp but in case of pixel format
>      more then 24bpp it would occur distortedness situation
>      on that mode. so this patch set the word swap control bit of
>      WINCONx to 1 as default value. but it should be set to 0
>      in case that each ENLOCAL bit of WINCON0 ~ 2 registers
>      is enabled. this issue would be solved with local path feature soon.

I prefer not to receive patches this way, sorry.  I will need to detach
the attachments, copy-n-paste the changelogs and signoffs and then
invent meaningful English-language titles for each patch.

The problem is the last part.  The titles I choose may be
inappropriate, and if anyone in a year's time tries to find the history
of a patch by googling for the title, they may not be able to find this
email thread.  A well-chosen title becomes a nice search key for looking
up the patch in reviewion control systems and on the 'net.

There are reasons for the conventions, so please let's be conventional.
Send it as three sequences-numbered emails, one with a carefully chosen
title/Subject: and each one with its own changelog, signoffs, etc.

Also, if you _must_ use attachments, please use text/plain mimetypes,
thanks.