Menu
▾
▴
Re: [Linux-fbdev-devel] [PATCH] fbdev: Fix test on unsigned in fb_do_show_logo()
|
From: Andrew M. <ak...@li...> - 2009-11-03 00:33:39
|
On Sat, 17 Oct 2009 00:45:14 +0200
Roel Kluin <roe...@gm...> wrote:
> image->d[xy] are unsigned so the check was wrong.
>
> Signed-off-by: Roel Kluin <roe...@gm...>
> ---
> diff --git a/drivers/video/fbmem.c b/drivers/video/fbmem.c
> index 99bbd28..9f20641 100644
> --- a/drivers/video/fbmem.c
> +++ b/drivers/video/fbmem.c
> @@ -403,7 +403,8 @@ static void fb_do_show_logo(struct fb_info *info, struct fb_image *image,
> image->dx += image->width + 8;
> }
> } else if (rotate == FB_ROTATE_UD) {
> - for (x = 0; x < num && image->dx >= 0; x++) {
> + for (x = 0; x < num && image->dx + image->width + 8 >= 0;
> + x++) {
> info->fbops->fb_imageblit(info, image);
> image->dx -= image->width + 8;
> }
> @@ -415,7 +416,8 @@ static void fb_do_show_logo(struct fb_info *info, struct fb_image *image,
> image->dy += image->height + 8;
> }
> } else if (rotate == FB_ROTATE_CCW) {
> - for (x = 0; x < num && image->dy >= 0; x++) {
> + for (x = 0; x < num && image->dy + image->height + 8 >= 0;
> + x++) {
> info->fbops->fb_imageblit(info, image);
> image->dy -= image->height + 8;
> }
Presumably that test isn't needed at all?
|
