Re: [Linux-fbdev-devel] [PATCH 1/2] fb: change rules for global rules match.

[Geert U. <ge...@li...>]

On Wed, Sep 23, 2009 at 06:42, Dave Airlie <ai...@gm...> wrote:
> From: Dave Airlie <ai...@li...>
>
> Having a : should be enough 'fb:' isn't really useful
> if the fb wants to a kms output ID.
>
> Andrew: I can push this via the drm tree if no objections, as
> I have a kms patch that requires it.
>
> Signed-off-by: Dave Airlie <ai...@re...>
> ---
>  drivers/video/fbmem.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/video/fbmem.c b/drivers/video/fbmem.c
> index a85c818..41a6162 100644
> --- a/drivers/video/fbmem.c
> +++ b/drivers/video/fbmem.c
> @@ -1789,7 +1789,7 @@ static int __init video_setup(char *options)
>                global = 1;
>        }
>
> -       if (!global && !strstr(options, "fb:")) {
> +       if (!global && !strstr(options, ":")) {
>                fb_mode_option = options;
>                global = 1;
>        }

Please don't use strstr() with single-character needle parameter strings.
Use strchr() instead.

Gcc may change such a strstr() to strchr() behind our back, causing
linking errors
on platforms that only provide an inline version of strchr().

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@li...

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds