Re: [Linux-fbdev-devel] [PATCH] aty128fb: move block to where it should be in function aty128_var_to_pll

[Benjamin H. <be...@ke...>]

On Mon, 2009-09-21 at 18:27 +0530, Jaswinder Singh Rajput wrote:
> Indentation is not an issue if I am not breaking any lines. I am
> moving
> the function where it should be and avoid unnecessary goto(break) and
> duplicate checking 'if (i == ARRAY_SIZE(post_dividers))'.

Where it "should be" is a matter of taste :-)

> > If you really want to silence that warning, just initialize the
> value
> > 
> 
> I am trying to save some CPU cycles and you are suggesting to add some
> more ;-)

Saving CPU cycles in the mode setting code ? :-)

Anyway, Paul maintains this driver afaik so it's his call :-)

Cheers,
Ben.