Re: [Linux-fbdev-devel] [PATCH] video: add PXA3xx accelerator ID [v2]

[Eric M. <eri...@gm...>]

> Ok, now remove 'cpu_is_pxa3xx() && ' above and you should be good to go:-)
> What if tomorrow pxa4xx comes (ok, Eric will disagree, but wtill:-))

It is not likely to be pxa4xx, (chinese people don't like '4', and there are
a lot chinese in Marvell, Shhh..... don't let them know I said this ;-)

Still, I guess having a cpu_is_pxa3xx() should be OK here.

>
>>       fbi->backlight_power = inf->pxafb_backlight_power;
>>       fbi->lcd_power = inf->pxafb_lcd_power;
>>
>> diff --git a/include/linux/fb.h b/include/linux/fb.h
>> index f847df9..a34bdf5 100644
>> --- a/include/linux/fb.h
>> +++ b/include/linux/fb.h
>> @@ -133,6 +133,7 @@ struct dentry;
>>  #define FB_ACCEL_NEOMAGIC_NM2230 96  /* NeoMagic NM2230              */
>>  #define FB_ACCEL_NEOMAGIC_NM2360 97  /* NeoMagic NM2360              */
>>  #define FB_ACCEL_NEOMAGIC_NM2380 98  /* NeoMagic NM2380              */
>> +#define FB_ACCEL_PXA3XX               99     /* PXA3xx                       */
>>
>>  #define FB_ACCEL_SAVAGE4        0x80 /* S3 Savage4                   */
>>  #define FB_ACCEL_SAVAGE3D       0x81 /* S3 Savage3D                  */
>> --
>> 1.6.3.3
>>
>
> Thanks
> Guennadi
> ---
> Guennadi Liakhovetski, Ph.D.
> Freelance Open-Source Software Developer
> http://www.open-technology.de/
>