[Linux-fbdev-devel] fsl-diu-fb: fix regression with uninitalized fb_info->mm_lock mutex

[Krzysztof H. <krz...@po...>]

From: Krzysztof Helt <krz...@wp...>

Remove redundant call to the fsl_diu_set_par before the register_framebuffer().

This fixes a problem with uninitialized the fb_info->mm_lock mutex introduced 
by the commit 537a1bf059f " fbdev: add mutex for fb_mmap locking"

Signed-off-by: Krzysztof Helt <krz...@wp...>

---
If anybody could test this patch with the 2.6.30-rc2 kernel I am deeply grateful.

The fb_set_par() function is called after register_framebuffer() when fbcon
is taking over the console so a call just before the register_framebuffer()
is redundant.

Regards,
Krzysztof

diff --git a/drivers/video/fsl-diu-fb.c b/drivers/video/fsl-diu-fb.c
index 0bf2190..72d68b3 100644
--- a/drivers/video/fsl-diu-fb.c
+++ b/drivers/video/fsl-diu-fb.c
@@ -1223,12 +1223,6 @@ static int __devinit install_fb(struct fb_info *info)
 		return -EINVAL;
 	}
 
-	if (fsl_diu_set_par(info)) {
-		printk(KERN_ERR "fb_set_par failed");
-		fb_dealloc_cmap(&info->cmap);
-		return -EINVAL;
-	}
-
 	if (register_framebuffer(info) < 0) {
 		printk(KERN_ERR "register_framebuffer failed");
 		unmap_video_memory(info);

----------------------------------------------------------------------
Rozwiaz krzyzowke i  wygraj nagrody! 
Sprawdz >>  http://link.interia.pl/f2232