[Linux-fbdev-devel] mx3fb: fix regression with uninitalized fb_info->mm_lock mutex

[Krzysztof H. <krz...@po...>]

From: Krzysztof Helt <krz...@wp...>

Remove redundant call to the mx3fb_set_par before the register_framebuffer().

This fixes a problem with uninitialized the fb_info->mm_lock mutex introduced 
by the commit 537a1bf059f " fbdev: add mutex for fb_mmap locking"

Signed-off-by: Krzysztof Helt <krz...@wp...>

---
Daniel,

Could you test this patch?

The mx3fb_set_par() is called from the register_framebuffer() anyway, so please check what 
to add to correctly unblank console for the first time. Maybe setting 

mx3_fbi->blank = FB_BLANK_UNBLANK;

before the call to register_framebuffer() is enough.

Regards,
Krzysztof

diff --git a/drivers/video/mx3fb.c b/drivers/video/mx3fb.c
index 567fb94..f8778cd 100644
--- a/drivers/video/mx3fb.c
+++ b/drivers/video/mx3fb.c
@@ -1365,11 +1365,6 @@ static int init_fb_chan(struct mx3fb_data *mx3fb, struct idmac_channel *ichan)
 	init_completion(&mx3fbi->flip_cmpl);
 	disable_irq(ichan->eof_irq);
 	dev_dbg(mx3fb->dev, "disabling irq %d\n", ichan->eof_irq);
-	ret = mx3fb_set_par(fbi);
-	if (ret < 0)
-		goto esetpar;
-
-	mx3fb_blank(FB_BLANK_UNBLANK, fbi);
 
 	dev_info(dev, "registered, using mode %s\n", fb_mode);
 

----------------------------------------------------------------------
Promocja ubezpieczen komunikacyjnych Ergo Hestia. Sprawdz!
http://link.interia.pl/f222f