Re: [Linux-fbdev-devel] [PATCH 18/19] drivers/video: Use PCI_VDEVICE

[Ville S. <sy...@sc...>]

On Fri, Jun 26, 2009 at 09:35:26AM -0700, Joe Perches wrote:
> On Fri, 2009-06-26 at 12:54 +0300, Ville Syrjälä wrote:
> > Perhaps there should be a PCI_VDDEVICE() or something for this type of
> > stuff? Would make things even shorter.
> 
> drivers/edac/edac_core.h has:
> 
> #define PCI_VEND_DEV(vend, dev) PCI_VENDOR_ID_ ## vend, \
> 	PCI_DEVICE_ID_ ## vend ## _ ## dev
> 
> Try submitting a patch and see what happens...

Too lazy. I was thinking that since you're already looking at
this stuff you might be tricked into doing some more work.

> > It seems your script missed atyfb. It could use PCI_VDEVICE() too.
> 
> Can you show an example please?

I didn't read you script and didn't look at the patches too closely. It
seems you only converted the open-coded stuff and not stuff already
using the PCI_DEVICE() macro. atyfb falls into this category.

-- 
Ville Syrjälä
sy...@sc...
http://www.sci.fi/~syrjala/