Re: [Linux-fbdev-devel] [PATCH 3/3] atyfb: Coding style cleanup

[H H. S. <har...@vi...>]

On Saturday, June 20, 2009 2:30 PM, Ville Syrjala wrote:
> Fix a bunch of coding style problems in atyfb_base.c.
> 
> Signed-off-by: Ville Syrjala <sy...@sc...>
> ---
> There are still some problems left, at least over 80 char lines, but
> fixing those in a decent manner would require some code restructuring
> to reduce the overly deep nesting. I decided to leave those bits mostly
> untouched for now.
> 
>  drivers/video/aty/atyfb_base.c |  829 ++++++++++++++++++++++------------------
>  1 files changed, 458 insertions(+), 371 deletions(-)
> 
> diff --git a/drivers/video/aty/atyfb_base.c b/drivers/video/aty/atyfb_base.c
> index 63d3739..913b4a4 100644
> --- a/drivers/video/aty/atyfb_base.c
> +++ b/drivers/video/aty/atyfb_base.c
> @@ -132,7 +132,7 @@
>  #endif
>  
>  #define PRINTKI(fmt, args...)	printk(KERN_INFO "atyfb: " fmt, ## args)
> -#define PRINTKE(fmt, args...)	 printk(KERN_ERR "atyfb: " fmt, ## args)
> +#define PRINTKE(fmt, args...)	printk(KERN_ERR "atyfb: " fmt, ## args)

Why not: 

#define pr_fmt(fmt)	"atyfb: " fmt

Then just use pr_info() and pr_err()?  Also, pr_devel() could be used instead
of the private DPRINTK() definition.

Regards,
Hartley