Re: [Linux-fbdev-devel] PATCH - Add accelerated bitblt functions to s1d13xxxfb

[Kristoffer E. <kri...@gm...>]

On Tue, 9 Jun 2009 17:58:07 -0700
Andrew Morton <ak...@li...> wrote:

> On Sat, 6 Jun 2009 14:10:37 +0200
> Kristoffer Ericson <kri...@gm...> wrote:
> 
> > This patch adds accelerated bitblt functions to s1d13xxx based 
> > video chipsets, more specificly functions copyarea and fillrect. 
> > It has only been tested and activated for 13506 chipsets
> > but is expected to work for the majority of s1d13xxx based chips.
> > This patch also cleans up the driver with respect of whitespaces
> > and other formatting issues. We update the current status
> > comments.
> > 
> 
> Was I sent half a patch?
> 
Sorry for late reply!

I must have missed appending the changes in s1d13xxx.h. Do you want a resend of the complete
patch or just whats missing? Here are the missing lines:

diff --git a/include/video/s1d13xxxfb.h b/include/video/s1d13xxxfb.h
index c3b2a2a..f0736cf 100644
--- a/include/video/s1d13xxxfb.h
+++ b/include/video/s1d13xxxfb.h
@@ -136,6 +136,15 @@
 #define S1DREG_DELAYOFF			0xFFFE
 #define S1DREG_DELAYON			0xFFFF
 
+#define BBLT_FIFO_EMPTY			0x00
+#define BBLT_FIFO_NOT_EMPTY		0x40
+#define BBLT_FIFO_NOT_FULL		0x30
+#define BBLT_FIFO_HALF_FULL		0x20
+#define BBLT_FIFO_FULL			0x10
+
+#define BBLT_SOLID_FILL			0x0c
+
+
 /* Note: all above defines should go in separate header files
    when implementing other S1D13xxx chip support. */
 


> 
> drivers/video/s1d13xxxfb.c: In function 'bltbit_fifo_status':
> drivers/video/s1d13xxxfb.c:470: error: 'BBLT_FIFO_EMPTY' undeclared (first use in this function)
> drivers/video/s1d13xxxfb.c:470: error: (Each undeclared identifier is reported only once
> drivers/video/s1d13xxxfb.c:470: error: for each function it appears in.)
> drivers/video/s1d13xxxfb.c:474: error: 'BBLT_FIFO_FULL' undeclared (first use in this function)
> drivers/video/s1d13xxxfb.c:478: error: 'BBLT_FIFO_NOT_FULL' undeclared (first use in this function)
> drivers/video/s1d13xxxfb.c: In function 's1d13xxxfb_bitblt_solidfill':
> drivers/video/s1d13xxxfb.c:640: error: 'BBLT_SOLID_FILL' undeclared (first use in this function)


-- 
Kristoffer Ericson <kri...@gm...>