Re: [Linux-fbdev-devel] [PATCH] atmel_lcdfb: Correct fifo size for some products

[Greg KH <gr...@su...>]

On Mon, Jun 08, 2009 at 05:36:20PM +0200, Nicolas Ferre wrote:
> Andrew Morton :
> > On Fri, 15 May 2009 12:34:18 +0200 Nicolas Ferre <nic...@at...> wrote:
> > 
> >> Remove wrong fifo size definition for some AT91 products.
> >>
> >> Due to a misunderstanding of some AT91 datasheets, a fifo size of 2048 (words)
> >> has been introduced by mistake. In fact, all products (AT91/AT32) are sharing
> >> the same fifo size of 512 words.
> >>
> > 
> > Changelog fails to describe the impact of the bug, so people who are
> > working out which kernel versions it should be ported into don't know
> > what to do.
> > 
> > Furthermore, people who are hitting a bug in this driver in older
> > kernel versions will have difficulty working out whether this patch
> > might fix their bug.
> 
> Ok, you are right, I will try to add some information.
> 
> In fact, if you mis-configure the fifo watermark making it too high you
> end without the capacity of issuing burst transfers on the internal AHB
> bus. This will decrease overall system performance as the LCD will ask
> for data as soon as the fifo will have one byte available (not efficient
> single accesses).
> 
> >> Can we consider this fix for .30-final ?
> > 
> > Sure, but for what reason?
> > 
> > What about 2.6.29.x, 2.6.28.x, earlier?
> 
> Indeed, should be valuable to extend this correction to stable kernel
> series. I added Greg to the loop for this purpose.

For stable stuff, please send any requested patches, with the git commit
id of the patch in Linus's tree, to st...@ke..., otherwise I might
miss it :)

Also, you can add:
	Cc: stable <st...@ke...>
to the signed-off-by area of the patch, and when it is taken into
Linus's tree, the stable team will automatically get notified of it and
include it in the next stable releases without any other work needed to
be done by you.

hope this helps,

greg k-h