From: Andrew M. <ak...@li...> - 2009-06-06 02:13:21
|
On Sat, 6 Jun 2009 11:38:32 +1000 Dave Airlie <ai...@gm...> wrote: > On Fri, Jun 5, 2009 at 11:51 PM, Peter Jones<pj...@re...> wrote: > > On 06/05/2009 02:07 AM, Dave Airlie wrote: > >> From: Dave Airlie <ai...@re...> > >> > >> With KMS we have ran into an issue where we really want the KMS fb driver > >> to be the one running the console, so panics etc can be shown by switching > >> out of X etc. > >> > >> However with vesafb/efifb built-in, we end up with those on fb0 and the > >> KMS fb driver on fb1, driving the same piece of hw, so this adds an fb info > >> flag to denote a firmware fbdev, and adds a new aperture base/size range > >> which can be compared when the hw drivers are installed to see if there > >> is a conflict with a firmware driver, and if there is the firmware driver is > >> unregistered and the hw driver takes over. > >> > >> It uses new aperture_base/size members instead of comparing on the fix > >> smem_start/length, as smem_start/length might for example only cover the > >> first 1MB of the PCI aperture, and we could allocate the kms fb from 8MB > >> into the aperture, thus they would never overlap. > >> > >> v2: add an fb_destroy callback so the firmware fb can cleanup after itself. > >> vesafb will now remove the region it reserves and destroy its fb info. > >> > >> Signed-off-by: Dave Airlie <ai...@re...> > > > > This version looks good to me. > > > > Acked-by: Peter Jones <pj...@re...> > > > > Andrew do we have an fbdev maintainer Tony suddenly vanished nearly two years ago. He did that once before, then resurfaced after six months - he'd been working in a remote village with no net connection. Hopefully he will reappear again. In the meanwhile I'm handling fbdev patches and Geert and Krzysztof are doing the technical work when time permits. I'll occasionally troll linux-fbdev-devel looking for patches which people send. > or can you pick this up for the next merge window? No probs. |