Re: [Linux-fbdev-devel] [PATCH] fb: add support of LCD display controller on pxa168/910 (base layer)

[Eric M. <eri...@gm...>]

On Mon, Jun 1, 2009 at 11:28 PM, Krzysztof Helt <krz...@po...> wrote:
> On Wed, 27 May 2009 16:21:11 +0800
> Eric Miao <eri...@gm...> wrote:
>
>> Hi Krzysztof,
>>
>> Sorry for late reply, and thanks for the time reviewing this.
>> See the revised version below with changes:
>>
>> 1. removed the unnecessary error checking of pseudo color
>> in check_var(). The pseudo color mode is actually be well
>> supported.
>>
>> 2. determine_best_pix_fmt() moved into check_var(), and
>> set_pix_fmt() is called to ensure a correct var.
>>
>> 3. set_graphics_start() removed from set_par
>>
>> 4. removed duplicate fields in pxa168fb_info and fb_info
>>
>> 5. correct the error exiting path
>>
>> 6. add __init attribute to pxa168fb_init_mode()
>>
>> ===================>8=======================
>>
>> From 27a53df0467f379de5ca2d6d117852fbaf93c2fc Mon Sep 17 00:00:00 2001
>> From: Lennert Buytenhek <bu...@ma...>
>> Date: Wed, 11 Feb 2009 17:25:24 +0800
>> Subject: [PATCH] fb: add support of LCD display controller on
>> pxa168/910 (base layer)
>>
>> This driver is originally written by Lennert, modified by Green to be
>> feature complete,  and ported by Jun Nie and Kevin Liu for pxa168/910
>> processors.
>>
>> The patch adds support for the on-chip LCD display controller, it
>> currently supports the base (graphics) layer only.
>>
>> Signed-off-by: Lennert Buytenhek <bu...@ma...>
>> Signed-off-by: Green Wan <gw...@ma...>
>> Cc: Peter Liao <pl...@ma...>
>> Signed-off-by: Jun Nie <nj...@ma...>
>> Signed-off-by: Kevin Liu <kl...@ma...>
>> Signed-off-by: Eric Miao <eri...@ma...>
>> ---
>
> Acked-by: Krzysztof Helt <krz...@wp...>
>
> You probably want to sent this patch to the RMK's tree.
> If not please sent it to Andrew Morton.

OK. And a big thanks for the time.