Re: [Linux-fbdev-devel] [PATCH] add mutex to fbdev for fb_mmap locking

[Krzysztof H. <krz...@po...>]

On Sun, 31 May 2009 10:09:01 -0700 (PDT)
Linus Torvalds <tor...@li...> wrote:

> 
> 
> On Sun, 31 May 2009, Krzysztof Helt wrote:
> >  
> >  static int atafb_get_fix(struct fb_fix_screeninfo *fix, struct fb_info *info)
> > +__acquires(&info->mm_lock)
> > +__releases(&info->mm_lock)
> 
> Btw, you shouldn't do this when things nest "correctly" - sparse will see 
> the fact that the function acquires and releases a lock and is perfectly 
> happy.
> 

I will fix it. 
If the revert to BKL is rejected this patch may wait till 2.6.31.

Regards,
Krzysztof