Re: [Linux-fbdev-devel] [PATCH] atmel_lcdfb: Correct fifo size for some products

[Andrew M. <ak...@li...>]

On Fri, 15 May 2009 12:34:18 +0200 Nicolas Ferre <nic...@at...> wrote:

> Remove wrong fifo size definition for some AT91 products.
> 
> Due to a misunderstanding of some AT91 datasheets, a fifo size of 2048 (words)
> has been introduced by mistake. In fact, all products (AT91/AT32) are sharing
> the same fifo size of 512 words.
> 

Changelog fails to describe the impact of the bug, so people who are
working out which kernel versions it should be ported into don't know
what to do.

Furthermore, people who are hitting a bug in this driver in older
kernel versions will have difficulty working out whether this patch
might fix their bug.

> Can we consider this fix for .30-final ?

Sure, but for what reason?

What about 2.6.29.x, 2.6.28.x, earlier?

> --- a/drivers/video/atmel_lcdfb.c
> +++ b/drivers/video/atmel_lcdfb.c
> @@ -29,14 +29,8 @@
>  
>  /* configurable parameters */
>  #define ATMEL_LCDC_CVAL_DEFAULT		0xc8
> -#define ATMEL_LCDC_DMA_BURST_LEN	8
> -
> -#if defined(CONFIG_ARCH_AT91SAM9263) || defined(CONFIG_ARCH_AT91CAP9) || \
> -	defined(CONFIG_ARCH_AT91SAM9RL)
> -#define ATMEL_LCDC_FIFO_SIZE		2048
> -#else
> -#define ATMEL_LCDC_FIFO_SIZE		512
> -#endif
> +#define ATMEL_LCDC_DMA_BURST_LEN	8	/* words */
> +#define ATMEL_LCDC_FIFO_SIZE		512	/* words */
>  
>  #if defined(CONFIG_ARCH_AT91)
>  #define	ATMEL_LCDFB_FBINFO_DEFAULT	(FBINFO_DEFAULT \