Re: [Linux-fbdev-devel] [PATCH] fbdev: does not allow VESA modes without compiled-in drivers (bug #13249)

[<krz...@po...>]

Andrew Morton napisał(a):
> On Wed, 20 May 2009 14:27:04 +0200 Krzysztof Helt >krz...@po...>
> wrote:
> 
> > From: Krzysztof Helt >krz...@wp...>
> > 
> > Does not allow to accept VESA modes by the "vga=" kernel parameter
> > if there is no frame buffer driver compiled-in to handle it.
> > 
> > Bug was reported by Werner Lemberg as kernel bug #13249
> > "Intel 945GM: Boot option`vga=0x31a' breaks display of TTYs".
> > 
> > Signed-off-by: Krzysztof Helt >krz...@wp...>
> > ---
> > 
> > Werner, please test it. It should produce a correct display
> > with intelfb compiled in (=y) and as a module (=m).
> > 
> > 
> > diff --git a/drivers/video/Kconfig b/drivers/video/Kconfig
> > index 0048f11..c787357 100644
> > --- a/drivers/video/Kconfig
> > +++ b/drivers/video/Kconfig
> > @@ -1122,7 +1122,7 @@ config FB_INTEL
> >  	select FB_CFB_FILLRECT
> >  	select FB_CFB_COPYAREA
> >  	select FB_CFB_IMAGEBLIT
> > -	select FB_BOOT_VESA_SUPPORT
> > +	select FB_BOOT_VESA_SUPPORT if FB_INTEL = y
> >  	help
> >  	  This driver supports the on-board graphics built in to the Intel
> >            830M/845G/852GM/855GM/865G/915G/915GM/945G/945GM/965G/965GM
> chipsets.
> > @@ -1460,7 +1460,7 @@ config FB_SIS
> >  	select FB_CFB_FILLRECT
> >  	select FB_CFB_COPYAREA
> >  	select FB_CFB_IMAGEBLIT
> > -	select FB_BOOT_VESA_SUPPORT
> > +	select FB_BOOT_VESA_SUPPORT if FB_SIS = y
> >  	help
> >  	  This is the frame buffer device driver for the SiS 300, 315, 330
> >  	  and 340 series as well as XGI V3XT, V5, V8, Z7 graphics chipsets.
> 
> I read through http://bugzilla.kernel.org/show_bug.cgi?id=13249 and am
> now unsure what to do with this patch?
> 
> 

Drop it. 

I think I know why my laptop uses PIPE_B but both pipes are active. The pipes are connected
to so called planes and driver must check which plane is enabled also.
Otherwise, when both pipes are enabled the driver doesn't know which one is used.

Finally, I found the documentation for i845.

Kind regards,
Krzysztof

----------------------------------------------------------------------
Kup wlasne mieszkanie za 33 tys. zl.
Sprawdz >>> http://link.interia.pl/f21a3