Re: [Linux-fbdev-devel] [PATCH] omapfb: Fix argument of blank operation.

[Felipe C. <fel...@gm...>]

On Thu, Mar 12, 2009 at 12:20 AM, Andrew Morton
<ak...@li...> wrote:
> On Wed, 11 Mar 2009 22:47:41 +0530
> Trilok Soni <son...@gm...> wrote:
>
>> Hi Felipe,
>>
>> On Fri, Dec 5, 2008 at 4:15 AM, Felipe Contreras
>
> I bet he thought we'd forgotten.

You bet correctly :)

>> <fel...@gm...> wrote:
>> > From: Felipe Contreras <fel...@no...>
>> >
>> > The blank operation should receive FB_BLANK_POWERDOWN, not
>> > VESA_POWERDOWN.
>> >
>>
>> Thanks. Looks good.
>>
>> Signed-off-by: Trilok Soni <son...@gm...>
>>
>
> Unfortunately the changelog didn't give me any hint as to the
> seriousness of the problem which was fixed.  So I queued it for 2.6.30,
> perhaps inappropriately.

I noticed because of another bug in omapfb which required blanking in
order to actually see something (PM stuff?). If user-space tries to
blank the usual way, it wouldn't work.

My guess is that it's not a big issue, in part because nobody has
noticed, but perhaps I'm wrong. I was hoping the fbdev guys would know
better.

-- 
Felipe Contreras