Re: [Linux-fbdev-devel] [Bugme-new] [Bug 12712] New: s2disk hangs with nvidiafb

[Sergei S. <ben...@op...>]

Hello.

By the way.

[drivers/video/vesafb.c
static int __init vesafb_probe(struct platform_device *dev)]

	if (!request_mem_region(vesafb_fix.smem_start, size_total, "vesafb")) {
		printk(KERN_WARNING
		       "vesafb: cannot reserve video memory at 0x%lx\n",
			vesafb_fix.smem_start);
		/* We cannot make this fatal. Sometimes this comes from magic
		   spaces our resource handlers simply don't know about */
	}

Is there any reason not to make vesafb request_mem_region fail fatal?

In case we already have framebuffer at 0xc0000000 and framebuffer_alloc failed -
we'll release non-vesafb memory region.

	info = framebuffer_alloc(sizeof(u32) * 256, &dev->dev);
	if (!info) {
		release_mem_region(vesafb_fix.smem_start, size_total);
		return -ENOMEM;
	}


So, what do you think about the idea to check num_registered_fb when request_mem_region 
fails?
----------------------------------------------------
...а теперь оплатить широкополосный доступ
в сеть Интернет ByFly можно электронными деньгами EasyPay.
http://www.easypay.by/