Re: [Linux-fbdev-devel] [REVIEW PATCH 8/9] DSS: support for Beagle Board

[David B. <da...@pa...>]

On Wednesday 05 November 2008, Jarkko Nikula wrote:
> > +     r = gpio_request(beagle_display_data_dvi.panel_reset_gpio, "DVI reset GPIO");
> > +     if(r < 0) {
> 
> GPIO label "DVI reset" is enough.

Surely this ** doesn't work ** at least against the OMAP git tree
which already has:

        omap_cfg_reg(J25_34XX_GPIO170);
        gpio_request(170, "DVI_nPD");
        /* REVISIT leave DVI powered down until it's needed ... */
        gpio_direction_output(170, true);

Label matches the DVI chip, not board schematics.  Agreed,
it's not a reset.

I'd like to see any FB/DSS/... updates have the property that
the TFP410 chip is powered down *unless* both (a) the frame
buffer/DSS/... driver is active, and (b) the DVI channel is
in use.

So for example a kernel without FB/DSS/... configured, that
DVI chip is never powered up.  And when only the S-Video channel
is used, DVI isn't powered up either.

- Dave