Re: [Linux-fbdev-users] [Linux-fbdev-devel] [PATCH] i.MX Framebuffer: Cleanup Coding style

[<krz...@po...>]

> On Mittwoch, 3. September 2008, Krzysztof Helt wrote:
> > On Tue,  2 Sep 2008 13:24:51 +0200
> >
> > Sascha Hauer <s....@pe...> wrote:
> > > Signed-off-by: Sascha Hauer <s....@pe...>
> > > ---
> > >  drivers/video/imxfb.c |   70
> > > +++++++++++++++++++++++------------------------- 1 files changed, 34
> > > insertions(+), 36 deletions(-)
> >
> > Acked-by: Krzysztof Helt <krz...@wp...>
> >
> > One offtopic comment: do you really want the FBINFO_READS_FAST set?
> >
> > It means that the driver prefer copyarea to imgblit function. It is
> 
> Did you ever get the framework to use the copyarea function the driver 
> provides? I tried it several times and this function was never called. 
> Independent from any flags I set or clear.
> 
> jbe
> 

I do not have atmel hardware to test. I did used the copyarea on some other drivers (tridentfb, pm2fb). The tdfxfb driver uses now copyarea function for console scrolling. I will inspect out the atmel driver and give you some hints.

Regards,
Krzysztof
> 


---------------------------------------------------------------
Nasilaja sie kradzieze.
Mieszkancy osiedli zaniepokojeni.
Prosimy o pomoc w tej sprawie >>> http://link.interia.pl/f1eef