Re: [Linux-fbdev-devel] [PATCH] eink_apollofb: new driver for Apollo eInk controller.

[Jaya K. <jay...@gm...>]

On Sun, Jul 13, 2008 at 10:20 AM, Andrew Morton
<ak...@li...> wrote:
> On Fri, 11 Jul 2008 17:54:31 +0300 Yauhen Kharuzhy <je...@gm...> wrote:
>
>> This driver has been developed for the OpenInkpot
>> project (http://openinkpot.org/).

Hi Yauhen,

I'm excited to see openinkpot.org. Excellent efforts.

> + *
> + * This driver based on hecubafb driver code.
> + *

If possible, please also CC me, I'm the author of hecubafb, defio, and
am always interested to know if people are finding it useful.

> The eink_apollofb driver supports many features of
> Apollo chip, in difference with the hecubafb driver:
> 2-bit color depth, partial picture loading, flash
> read/write.

Yes, you've done good work here. I see the additions you've made as
support for 2-bit, partial updates and also suspend/resume.

However, I should point out that hecubafb is a driver for this same
apollo controller. There are several names for the Apollo controller
including PVI-1006A, Hecuba among others. Looking at the diff between
your work above and hecubafb, I think it should be feasible to add
your code to hecubafb rather than to create a new driver. Please let
me know if there's any problems achieving that, I'll be happy to help.

Thanks,
jaya