From: Eric M. <ym...@ma...> - 2008-05-12 03:25:46
|
> -----Original Message----- > From: Jaya Kumar [mailto:jay...@gm...] > Sent: Monday, May 12, 2008 11:23 AM > To: Eric Miao > Cc: Linux Frame Buffer Device Development > Subject: Re: Debugging pxafb and am200epd > > On Sun, May 11, 2008 at 11:07 PM, Eric Miao <ym...@ma...> wrote: > > > > The pxafb_init() should really be __init, as well as the pxafb_probe(), since > > the device itself isn't a hotplug one, according to the > ocumentation/PCI/pci.txt > > I got things to work only if I set pxafb_init to __init and > pxafb_probe as __devinit. With pxafb_probe as __init, the overlap > still occurred. I think this is consistent with the explanation in > pci.txt. > Please also try modify pxafb_setup_options() and g_options[] to __init, I don't think they deserve a __devinit either. > > > > And I think it's better to fire a separate patch to fix this. > > Agreed. I'll make sure to do each of the patches as individual ones. > > > > >> While I was doing this, I cooked up the following patch to pxafb to > >> make it unloadable. I've appended the code below. If it looks okay to > >> you, I would like to test it a bit and then submit it as a patch. > >> > > > > This is good, I like this one. Please also submit to the linux-arm-kernel > > <lin...@li...>, we have some users there who > > might be also interested in a removable pxafb driver. > > > > Ok, will do. > > Thanks, > jaya |