Re: [Linux-fbdev-devel] [PATCH 4/5] x86_64 EFI support -v3: EFI framebuffer driver

[Huang, Y. <yin...@in...>]

On Wed, 2007-08-01 at 13:55 +0800, Antonino A. Daplas wrote:
> On Tue, 2007-07-31 at 11:13 +0800, Huang, Ying wrote:
> 
> > +
> > +#include <linux/delay.h>
> > +#include <linux/errno.h>
> > +#include <linux/fb.h>
> > +#include <linux/kernel.h>
> > +#include <linux/init.h>
> > +#include <linux/ioport.h>
> > +#include <linux/mm.h>
> > +#include <linux/module.h>
> > +#include <linux/platform_device.h>
> > +#include <linux/screen_info.h>
> > +#include <linux/slab.h>
> > +#include <linux/string.h>
> > +#include <linux/dmi.h>
> > +#include <linux/efi.h>
> > +#include <linux/io.h>
> > +
> > +#include <video/vga.h>
> > +
> 
> I don't see any problems with this driver, just a few minor nits.
> 
> Do you really need all the #include's?

There are some #include's that are not needed. I will remove them in the
next version.

> I presume this driver only supports bpp 16 and above?

Yes. Only the true color visual is supported. I think only bpp 16 and
above can support true color visual.

Best Regards,
Huang Ying