From: Antonino A. D. <ad...@gm...> - 2005-07-23 05:06:24
|
On Saturday 02 July 2005 08:56, Jon Smirl wrote: > Another way to think of this, let's make another member variable > .fb_hwcursor. When the driver has a hardware cusor is sets > .fb_hwcursor. If you want to use the software cursor use the exisiting > .fb_cursor. > > If you think about it every driver is going to have the exact same > assignment .fb_cursor = soft_cursor. If every driver is going to have > exactly the same assignment, why do we need the variable? > > It's the existence of the hardware cursor that varies from driver to > driver, that's the one we need the variable for. Is this resolved? I tend to agree with Jon. Let's just remove all references to soft_cursor from all drivers, and let fbcon_cursor() fall back to soft_cursor when xxxfb_cursor() is absent. It is a lot cleaner and saner this way, and although it touches all drivers, it is a singe logical change, so it's acceptable. Also, I think it might be preferable to have 2 cursor hooks, one is fbcon-specific, and the other is for use only in userspace, which needs to be more comprehensive. Or if a single but comprehensive cursor API is preferred, then we just adapt fbcon_cursor to use the more powerful cursor API. So, anyone want to propose a cursor API for fbdev, that is both usable by fbcon and userspace? Tony |