Re: [Linux-fbdev-devel] Re: [macro@ds2.pg.gda.pl: Re: PMAG-A support?]

[Maciej W. R. <ma...@ds...>]

On Thu, 14 Aug 2003, Thiemo Seufer wrote:

> >  I've looked at the patch and have changed the barriers as I deem
> > appropriate.  But while doing this, I've noticed the code is insonsistent
> > in a few places -- has it been successfully verified on real hardware?
> 
> It works on my /260. Which parts look weird to you?

1. bt431_write_reg_inc() uses u16 for value, even though it only uses 8
bits (which of course makes all the calls in bt431_init_cursor() dubious). 

2. bt431_load_cursor_sprite() loads control registers instead of the
cursor map. 

 See the patch for details.  You may use `diff -b' to get rid of spacing
clean-ups -- this makes my updates quite clear. 

  Maciej

-- 
+  Maciej W. Rozycki, Technical University of Gdansk, Poland   +
+--------------------------------------------------------------+
+        e-mail: ma...@ds..., PGP key available        +