Re: [Linux-fbdev-devel] Re: [macro@ds2.pg.gda.pl: Re: PMAG-A support?]

[Maciej W. R. <ma...@ds...>]

On Tue, 12 Aug 2003, Thiemo Seufer wrote:

> Anyway, the AA driver is appended as a diff against current linux-mips
> CVS. I hope it doesn't deviate too much from whatever fbdev uses.

 Hmm, I can only see PMAG-A-specific changes here -- does it mean the
driver now works as is with no changes to the generic fb code?  If that is
the case, I'll apply the patch to the MIPS CVS right now.

 One point to note -- iob() is a heavyweight barrier implying immediate
draining of buffers.  I don't think it's really needed here as the driver
only needs to enforce ordering.  Hence I'd change iob() to wmb() or mb()
as appropriate and add a few missing rmb() calls.  I can do that when
applying the patch or please prepare an update.

  Maciej

-- 
+  Maciej W. Rozycki, Technical University of Gdansk, Poland   +
+--------------------------------------------------------------+
+        e-mail: ma...@ds..., PGP key available        +