From: Jesper J. <juh...@di...> - 2005-03-20 16:39:23
|
Having a semicolon at the end as in labelname:; is pointless, remove. Signed-off-by: Jesper Juhl <juh...@di...> diff -up linux-2.6.11-mm4-orig/drivers/video/matrox/matroxfb_maven.c linux-2.6.11-mm4/drivers/video/matrox/matroxfb_maven.c --- linux-2.6.11-mm4-orig/drivers/video/matrox/matroxfb_maven.c 2005-03-02 08:37:30.000000000 +0100 +++ linux-2.6.11-mm4/drivers/video/matrox/matroxfb_maven.c 2005-03-20 17:35:48.000000000 +0100 @@ -1263,11 +1263,11 @@ static int maven_detect_client(struct i2 if (err) goto ERROR4; return 0; -ERROR4:; +ERROR4: i2c_detach_client(new_client); -ERROR3:; +ERROR3: kfree(new_client); -ERROR0:; +ERROR0: return err; } |
From: Petr V. <van...@vc...> - 2005-03-20 19:17:38
|
On Sun, Mar 20, 2005 at 05:41:01PM +0100, Jesper Juhl wrote: > > Having a semicolon at the end as in labelname:; is pointless, remove. As long as I'm maintainer of this code, I prefer to leave them here. Petr Vandrovec > > Signed-off-by: Jesper Juhl <juh...@di...> > > diff -up linux-2.6.11-mm4-orig/drivers/video/matrox/matroxfb_maven.c linux-2.6.11-mm4/drivers/video/matrox/matroxfb_maven.c > --- linux-2.6.11-mm4-orig/drivers/video/matrox/matroxfb_maven.c 2005-03-02 08:37:30.000000000 +0100 > +++ linux-2.6.11-mm4/drivers/video/matrox/matroxfb_maven.c 2005-03-20 17:35:48.000000000 +0100 > @@ -1263,11 +1263,11 @@ static int maven_detect_client(struct i2 > if (err) > goto ERROR4; > return 0; > -ERROR4:; > +ERROR4: > i2c_detach_client(new_client); > -ERROR3:; > +ERROR3: > kfree(new_client); > -ERROR0:; > +ERROR0: > return err; > } > > > > |
From: Jesper J. <juh...@di...> - 2005-03-20 19:32:44
|
On Sun, 20 Mar 2005, Petr Vandrovec wrote: > On Sun, Mar 20, 2005 at 05:41:01PM +0100, Jesper Juhl wrote: > > > > Having a semicolon at the end as in labelname:; is pointless, remove. > > As long as I'm maintainer of this code, I prefer to leave them here. > Petr Vandrovec > No problem. As you say, you're the maintainer. I just spotted them and made the patch, it's ofcourse entirely up to you if you want to apply it or not :-) -- Jesper Juhl |