From: Jani M. <ja...@iv...> - 2002-08-28 06:58:22
|
James Should't gen_set_var set the var in info here as well? (when no check_var present) BTW is gen_set_var going to stay in the new API or go away ? --- fbgen.c.orig Wed Aug 28 09:49:45 2002 +++ fbgen.c Wed Aug 28 09:57:32 2002 @@ -36,7 +36,7 @@ if (con < 0 || (memcmp(&info->var, var, sizeof(struct fb_var_screeninfo)))) { if (!info->fbops->fb_check_var) { - *var = info->var; + info->var = *var; return 0; } |
From: Antonino D. <ad...@po...> - 2002-08-28 09:03:19
|
On Wed, 2002-08-28 at 18:00, Jani Monoses wrote: > James > Should't gen_set_var set the var in info here as well? (when no check_var present) > BTW is gen_set_var going to stay in the new API or go away ? > > --- fbgen.c.orig Wed Aug 28 09:49:45 2002 > +++ fbgen.c Wed Aug 28 09:57:32 2002 > @@ -36,7 +36,7 @@ > > if (con < 0 || (memcmp(&info->var, var, sizeof(struct fb_var_screeninfo)))) { > if (!info->fbops->fb_check_var) { > - *var = info->var; > + info->var = *var; > return 0; > } > > The original code is correct. It means the driver supports only 1 video mode, which is the current one in info->var. Tony |
From: Jani M. <ja...@iv...> - 2002-08-28 09:14:17
|
Thanks so not having check_var implies we only support one video mode? > > > > > The original code is correct. It means the driver supports only 1 video > mode, which is the current one in info->var. > > Tony > > > > > ------------------------------------------------------- > This sf.net email is sponsored by: Jabber - The world's fastest growing > real-time communications platform! Don't just IM. Build it in! > http://www.jabber.com/osdn/xim > _______________________________________________ > Linux-fbdev-devel mailing list > Lin...@li... > https://lists.sourceforge.net/lists/listinfo/linux-fbdev-devel |
From: Geert U. <ge...@li...> - 2002-08-28 09:20:09
|
On Wed, 28 Aug 2002, Jani Monoses wrote: > so not having check_var implies we only support one video mode? Yes. This is useful for e.g. handheld devices with LCDs, and for offb. > > The original code is correct. It means the driver supports only 1 video > > mode, which is the current one in info->var. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@li... In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds |
From: James S. <jsi...@in...> - 2002-08-28 18:20:08
|
> James > Should't gen_set_var set the var in info here as well? (when no check_var present) No. The first test is to see if the passed in var is equal to the current var in info. Note info->var is always set before we call gen_set_var. The next set is check if xxfb_check_var is there. If this function is lacking then we know the hardware supports a static mode. Then it just returns the defualt var which is set before we call gen_set_var. > BTW is gen_set_var going to stay in the new API or go away ? It is to stay. It will be intergrated into fbmem.c once we are done. > --- fbgen.c.orig Wed Aug 28 09:49:45 2002 > +++ fbgen.c Wed Aug 28 09:57:32 2002 > @@ -36,7 +36,7 @@ > > if (con < 0 || (memcmp(&info->var, var, sizeof(struct fb_var_screeninfo)))) { > if (!info->fbops->fb_check_var) { > - *var = info->var; > + info->var = *var; > return 0; > } MS: (n) 1. A debilitating and surprisingly widespread affliction that renders the sufferer barely able to perform the simplest task. 2. A disease. James Simmons [jsi...@us...] ____/| fbdev/console/gfx developer \ o.O| http://www.linux-fbdev.org =(_)= http://linuxgfx.sourceforge.net U http://linuxconsole.sourceforge.net |