linux-fbdev-devel

[Linux-fbdev-devel] Why do I get this error in aty128fb.c

[Otto W. <ott...@bl...>]

I tried to set the debug option in the driver "aty128fb.c" but get this
error:

aty128fb.c: In function `aty128_reset_engine':
aty128fb.c:655: parse error before `)'
Source:-------------------------------------------
...
#define DEBUG
#ifdef DEBUG
#define DBG(fmt, args...)	printk(KERN_DEBUG "aty128fb: %s " fmt,
__FUNCTION__, ## args);
#else
#define DBG(fmt, args...)
#endif
...
    DBG("engine reset");
    ^^^^^^^^^^^^^^^^^^^
    here comes the error
--------------------------------------------------

From the gcc manual this should be okay.

I'm using kernel 2.4.3 and a Debian woody system.

Re: [Linux-fbdev-devel] Why do I get this error in aty128fb.c

[Brad D. <br...@ne...>]

On 15 Jun 2001 21:28:27 +0200, Otto Wyss wrote:
> I tried to set the debug option in the driver "aty128fb.c" but get this
> error:
> 
> aty128fb.c: In function `aty128_reset_engine':
> aty128fb.c:655: parse error before `)'
> Source:-------------------------------------------
> ...
> #define DEBUG
> #ifdef DEBUG
> #define DBG(fmt, args...)	printk(KERN_DEBUG "aty128fb: %s " fmt,
> __FUNCTION__, ## args);
> #else
> #define DBG(fmt, args...)
> #endif
> ...
>     DBG("engine reset");
>     ^^^^^^^^^^^^^^^^^^^
>     here comes the error

Is this in the 2.2.x kernel?  Hmm, that should have been changed to match
modern gcc awhile ago.  I guess the patch was never accepted.

Change that line to:

DBG("engine reset %s", "");

Brad Douglas
br...@ne...

Re: [Linux-fbdev-devel] Why do I get this error in aty128fb.c

[Otto W. <ott...@bl...>]

> Is this in the 2.2.x kernel?  Hmm, that should have been changed to match
> modern gcc awhile ago.  I guess the patch was never accepted.
> 
No it's in kernel 2.4.3 and probably in 2.4.5 as well.

> Change that line to:
> 
> DBG("engine reset %s", "");
> 
This should not be necessary, if I interpret the gcc manual correct (see
"http://gcc.gnu.org/onlinedocs/gcc-2.95.3/gcc_4.html#SEC76"). 

O. Wyss

Re: [Linux-fbdev-devel] Why do I get this error in aty128fb.c

[Brad D. <br...@ne...>]

On 15 Jun 2001 22:25:44 +0200, Otto Wyss wrote:
> > Is this in the 2.2.x kernel?  Hmm, that should have been changed to match
> > modern gcc awhile ago.  I guess the patch was never accepted.
> > 
> No it's in kernel 2.4.3 and probably in 2.4.5 as well.
> 
> > Change that line to:
> > 
> > DBG("engine reset %s", "");
> > 
> This should not be necessary, if I interpret the gcc manual correct (see
> "http://gcc.gnu.org/onlinedocs/gcc-2.95.3/gcc_4.html#SEC76"). 

You'd think so.  And in fact, at one point, it DID work as documented.

It's just a minor inconvenience at worst, but if you'd like to make note
of that to the gcc people, I'd appreciate it.

Brad Douglas
br...@ne...