From: Trilok S. <son...@gm...> - 2007-06-26 12:33:56
Attachments:
0001-OMAP-Add-TI-OMAP-framebuffer-driver.patch
|
-- --Trilok Soni |
From: Sam R. <sa...@ra...> - 2007-06-26 16:49:05
|
diff --git a/drivers/video/omap/Makefile b/drivers/video/omap/Makefile new file mode 100644 index 0000000..5aa7175 --- /dev/null +++ b/drivers/video/omap/Makefile @@ -0,0 +1,10 @@ +# +# Makefile for the new OMAP framebuffer device driver +# + +obj-$(CONFIG_FB_OMAP) += omapfb.o + +objs-yy := omapfb_main.o + +omapfb-objs := $(objs-yy) + This looks strangs. Please use: obj-$(CONFIG_FB_OMAP) += omapfb.o omapfb-y := omapfb_main.o Or even better rename your .c file to omapfb.c then you only need to use: obj-$(CONFIG_FB_OMAP) += omapfb.o Sam |
From: Trilok S. <son...@gm...> - 2007-06-27 08:44:09
|
Hi Sam, On 6/26/07, Sam Ravnborg <sa...@ra...> wrote: > diff --git a/drivers/video/omap/Makefile b/drivers/video/omap/Makefile > new file mode 100644 > index 0000000..5aa7175 > --- /dev/null > +++ b/drivers/video/omap/Makefile > @@ -0,0 +1,10 @@ > +# > +# Makefile for the new OMAP framebuffer device driver > +# > + > +obj-$(CONFIG_FB_OMAP) += omapfb.o > + > +objs-yy := omapfb_main.o > + > +omapfb-objs := $(objs-yy) > + > > This looks strangs. > Please use: > obj-$(CONFIG_FB_OMAP) += omapfb.o > > omapfb-y := omapfb_main.o > > Or even better rename your .c file to omapfb.c then > you only need to use: > obj-$(CONFIG_FB_OMAP) += omapfb.o > Thanx for the review. I will incorporate your suggestions into the next update of fb patches. -- --Trilok Soni |