From: Antonino A. D. <ad...@gm...> - 2006-05-28 00:43:36
|
CONFIG_FB = m and CONFIG_{BACKLIGHT:LCD}_CLASS_DEVICE = y is possible resulting in link errors. Fix by making backlight and lcd class also depend on FB Signed-off-by: Antonino Daplas <ad...@po...> --- drivers/video/backlight/Kconfig | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/video/backlight/Kconfig b/drivers/video/backlight/Kconfig index 02f1529..022f9d3 100644 --- a/drivers/video/backlight/Kconfig +++ b/drivers/video/backlight/Kconfig @@ -10,7 +10,7 @@ menuconfig BACKLIGHT_LCD_SUPPORT config BACKLIGHT_CLASS_DEVICE tristate "Lowlevel Backlight controls" - depends on BACKLIGHT_LCD_SUPPORT + depends on BACKLIGHT_LCD_SUPPORT && FB default m help This framework adds support for low-level control of the LCD @@ -26,7 +26,7 @@ config BACKLIGHT_DEVICE config LCD_CLASS_DEVICE tristate "Lowlevel LCD controls" - depends on BACKLIGHT_LCD_SUPPORT + depends on BACKLIGHT_LCD_SUPPORT && FB default m help This framework adds support for low-level control of LCD. |
From: Andrew M. <ak...@os...> - 2006-05-28 06:18:55
|
On Sun, 28 May 2006 08:42:07 +0800 "Antonino A. Daplas" <ad...@gm...> wrote: > CONFIG_FB = m and CONFIG_{BACKLIGHT:LCD}_CLASS_DEVICE = y is possible > resulting in link errors. Fix by making backlight and lcd class also > depend on FB > > Signed-off-by: Antonino Daplas <ad...@po...> > --- > > drivers/video/backlight/Kconfig | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/video/backlight/Kconfig b/drivers/video/backlight/Kconfig > index 02f1529..022f9d3 100644 > --- a/drivers/video/backlight/Kconfig > +++ b/drivers/video/backlight/Kconfig > @@ -10,7 +10,7 @@ menuconfig BACKLIGHT_LCD_SUPPORT > > config BACKLIGHT_CLASS_DEVICE > tristate "Lowlevel Backlight controls" > - depends on BACKLIGHT_LCD_SUPPORT > + depends on BACKLIGHT_LCD_SUPPORT && FB > default m > help > This framework adds support for low-level control of the LCD > @@ -26,7 +26,7 @@ config BACKLIGHT_DEVICE > > config LCD_CLASS_DEVICE > tristate "Lowlevel LCD controls" > - depends on BACKLIGHT_LCD_SUPPORT > + depends on BACKLIGHT_LCD_SUPPORT && FB > default m > help > This framework adds support for low-level control of LCD. Would I be correct in believing that this is a mainline fix and hence 2.6.17 material? |
From: Antonino A. D. <ad...@gm...> - 2006-05-28 06:49:27
|
Andrew Morton wrote: > On Sun, 28 May 2006 08:42:07 +0800 > "Antonino A. Daplas" <ad...@gm...> wrote: > >> CONFIG_FB = m and CONFIG_{BACKLIGHT:LCD}_CLASS_DEVICE = y is possible >> resulting in link errors. Fix by making backlight and lcd class also >> depend on FB >> >> Signed-off-by: Antonino Daplas <ad...@po...> >> --- >> >> drivers/video/backlight/Kconfig | 4 ++-- >> 1 files changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/video/backlight/Kconfig b/drivers/video/backlight/Kconfig >> index 02f1529..022f9d3 100644 >> --- a/drivers/video/backlight/Kconfig >> +++ b/drivers/video/backlight/Kconfig >> @@ -10,7 +10,7 @@ menuconfig BACKLIGHT_LCD_SUPPORT >> >> config BACKLIGHT_CLASS_DEVICE >> tristate "Lowlevel Backlight controls" >> - depends on BACKLIGHT_LCD_SUPPORT >> + depends on BACKLIGHT_LCD_SUPPORT && FB >> default m >> help >> This framework adds support for low-level control of the LCD >> @@ -26,7 +26,7 @@ config BACKLIGHT_DEVICE >> >> config LCD_CLASS_DEVICE >> tristate "Lowlevel LCD controls" >> - depends on BACKLIGHT_LCD_SUPPORT >> + depends on BACKLIGHT_LCD_SUPPORT && FB >> default m >> help >> This framework adds support for low-level control of LCD. > > Would I be correct in believing that this is a mainline fix and hence > 2.6.17 material? > It's mainline fix, though I would say that it's not urgent. Tony |