From: Dan C. <er...@gm...> - 2009-11-22 14:21:37
|
Fixed a typo: missing *. This would lead to a kernel oops if the kernel was compiled without support for the /proc file system. Found with a static checker. Compile tested. regards, dan carpenter Signed-off-by: Dan Carpenter <er...@gm...> --- orig/drivers/video/via/viafbdev.c 2009-11-21 14:44:33.000000000 +0200 +++ devel/drivers/video/via/viafbdev.c 2009-11-21 14:44:43.000000000 +0200 @@ -1797,7 +1797,7 @@ static const struct file_operations viaf static void viafb_init_proc(struct proc_dir_entry **viafb_entry) { *viafb_entry = proc_mkdir("viafb", NULL); - if (viafb_entry) { + if (*viafb_entry) { proc_create("dvp0", 0, *viafb_entry, &viafb_dvp0_proc_fops); proc_create("dvp1", 0, *viafb_entry, &viafb_dvp1_proc_fops); proc_create("dfph", 0, *viafb_entry, &viafb_dfph_proc_fops); |
From: Florian T. S. <Flo...@gm...> - 2009-11-25 17:46:56
|
Hi, nice catch. Your patch is obviously correct. Please send it to Andrew Morton <ak...@li...> to get it into mainline. Dan Carpenter schrieb: > Fixed a typo: missing *. This would lead to a kernel oops if the kernel > was compiled without support for the /proc file system. > > Found with a static checker. Compile tested. > > regards, > dan carpenter > > Signed-off-by: Dan Carpenter <er...@gm...> Acked-by: Florian Tobias Schandinat <Flo...@gm...> > > --- orig/drivers/video/via/viafbdev.c 2009-11-21 14:44:33.000000000 +0200 > +++ devel/drivers/video/via/viafbdev.c 2009-11-21 14:44:43.000000000 +0200 > @@ -1797,7 +1797,7 @@ static const struct file_operations viaf > static void viafb_init_proc(struct proc_dir_entry **viafb_entry) > { > *viafb_entry = proc_mkdir("viafb", NULL); > - if (viafb_entry) { > + if (*viafb_entry) { Thanks, Florian Tobias Schandinat |