linux-fbdev-devel

[Linux-fbdev-devel] [PATCH] video: s3c_fb.c: fix build with CONFIG_HOTPLUG=n

[Peter K. <ja...@su...>]

Fixes `s3c_fb_remove' referenced in section `.data' of
drivers/built-in.o: defined in discarded section `.devexit.text' of
drivers/built-in.o

With CONFIG_HOTPLUG=n functions marked with __devexit gets removed, so
make sure we use __devexit_p when referencing pointers to them.

Signed-off-by: Peter Korsgaard <ja...@su...>
---
 drivers/video/s3c-fb.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/video/s3c-fb.c b/drivers/video/s3c-fb.c
index d3a568e..db71de1 100644
--- a/drivers/video/s3c-fb.c
+++ b/drivers/video/s3c-fb.c
@@ -1018,7 +1018,7 @@ static int s3c_fb_resume(struct platform_device *pdev)
 
 static struct platform_driver s3c_fb_driver = {
 	.probe		= s3c_fb_probe,
-	.remove		= s3c_fb_remove,
+	.remove		= __devexit_p(s3c_fb_remove),
 	.suspend	= s3c_fb_suspend,
 	.resume		= s3c_fb_resume,
 	.driver		= {
-- 
1.6.2

Re: [Linux-fbdev-devel] [PATCH] video: s3c_fb.c: fix build with CONFIG_HOTPLUG=n

[Ben D. <ben...@fl...>]

On Sun, Jun 07, 2009 at 03:05:39PM +0200, Peter Korsgaard wrote:
> Fixes `s3c_fb_remove' referenced in section `.data' of
> drivers/built-in.o: defined in discarded section `.devexit.text' of
> drivers/built-in.o
> 
> With CONFIG_HOTPLUG=n functions marked with __devexit gets removed, so
> make sure we use __devexit_p when referencing pointers to them.
> 
> Signed-off-by: Peter Korsgaard <ja...@su...>
Acked-by: Ben Dooks <ben...@fl...>
> ---
>  drivers/video/s3c-fb.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/video/s3c-fb.c b/drivers/video/s3c-fb.c
> index d3a568e..db71de1 100644
> --- a/drivers/video/s3c-fb.c
> +++ b/drivers/video/s3c-fb.c
> @@ -1018,7 +1018,7 @@ static int s3c_fb_resume(struct platform_device *pdev)
>  
>  static struct platform_driver s3c_fb_driver = {
>  	.probe		= s3c_fb_probe,
> -	.remove		= s3c_fb_remove,
> +	.remove		= __devexit_p(s3c_fb_remove),
>  	.suspend	= s3c_fb_suspend,
>  	.resume		= s3c_fb_resume,
>  	.driver		= {
> -- 
> 1.6.2
> 
> 
> -------------------------------------------------------------------
> List admin: http://lists.arm.linux.org.uk/mailman/listinfo/linux-arm-kernel
> FAQ:        http://www.arm.linux.org.uk/mailinglists/faq.php
> Etiquette:  http://www.arm.linux.org.uk/mailinglists/etiquette.php

-- 
-- 
Ben

Q:      What's a light-year?
A:      One-third less calories than a regular year.

[Linux-fbdev-devel] [PATCH RESEND] video: s3c_fb.c: fix build with CONFIG_HOTPLUG=n

[Peter K. <ja...@su...>]

Fixes `s3c_fb_remove' referenced in section `.data' of
drivers/built-in.o: defined in discarded section `.devexit.text' of
drivers/built-in.o

With CONFIG_HOTPLUG=n, functions marked with __devexit gets removed,
so make sure we use __devexit_p when referencing pointers to them.

Signed-off-by: Peter Korsgaard <ja...@su...>
Acked-by: Ben Dooks <ben...@fl...>
---
 drivers/video/s3c-fb.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Seems like this never made it to mainline, even though Ben acked it back
in June. Andrew, please push to Linus.

diff --git a/drivers/video/s3c-fb.c b/drivers/video/s3c-fb.c
index 5a72083..adf9632 100644
--- a/drivers/video/s3c-fb.c
+++ b/drivers/video/s3c-fb.c
@@ -1036,7 +1036,7 @@ static int s3c_fb_resume(struct platform_device *pdev)
 
 static struct platform_driver s3c_fb_driver = {
 	.probe		= s3c_fb_probe,
-	.remove		= s3c_fb_remove,
+	.remove		= __devexit_p(s3c_fb_remove),
 	.suspend	= s3c_fb_suspend,
 	.resume		= s3c_fb_resume,
 	.driver		= {
-- 
1.6.3.3