From: Martin M. <tb...@cy...> - 2007-11-08 08:22:21
|
Jan Rinze noticed that 16bpp screen mode is not working on Netwinder: "After some deduction it appeared that it was running in 24bpp instead of 16bpp. Found the bug: a missing 'break' statement at the end of a switch case. After adding the break statement 16bpp works fine." Signed-off-by: Martin Michlmayr <tb...@cy...> Cc: Jan Rinze <jan...@ho...> Cc: Woody Suwalski <wo...@su...> --- a/drivers/video/cyber2000fb.c +++ b/drivers/video/cyber2000fb.c @@ -874,6 +874,8 @@ static int cyber2000fb_set_par(struct fb_info *info) default: BUG(); } + break; + case 24:/* TRUECOLOUR, 16m */ hw.co_pixfmt = CO_PIXFMT_24BPP; hw.width *= 3; -- Martin Michlmayr http://www.cyrius.com/ |
From: Woody <wo...@su...> - 2007-11-08 13:03:08
|
Martin Michlmayr wrote: > Jan Rinze noticed that 16bpp screen mode is not working on Netwinder: > "After some deduction it appeared that it was running in 24bpp instead > of 16bpp. Found the bug: a missing 'break' statement at the end of a > switch case. After adding the break statement 16bpp works fine." > > Signed-off-by: Martin Michlmayr <tb...@cy...> > Cc: Jan Rinze <jan...@ho...> > Cc: Woody Suwalski <wo...@su...> > > --- a/drivers/video/cyber2000fb.c > +++ b/drivers/video/cyber2000fb.c > @@ -874,6 +874,8 @@ static int cyber2000fb_set_par(struct fb_info *info) > default: > BUG(); > } > + break; > + > case 24:/* TRUECOLOUR, 16m */ > hw.co_pixfmt = CO_PIXFMT_24BPP; > hw.width *= 3; > > Yes, with the above bug fix I have tested that 16-bit X fbdev works OK. Woody |
From: Martin M. <tb...@cy...> - 2007-11-10 16:52:37
|
* Martin Michlmayr <tb...@cy...> [2007-11-08 09:22]: > Jan Rinze noticed that 16bpp screen mode is not working on Netwinder: > "After some deduction it appeared that it was running in 24bpp instead > of 16bpp. Found the bug: a missing 'break' statement at the end of a > switch case. After adding the break statement 16bpp works fine." You can ignore this patch. It went in via Russell King already, see http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=c2ec21c5c8f15c079c209f403d582f3134785060 -- Martin Michlmayr http://www.cyrius.com/ |