From: <ak...@os...> - 2005-07-01 05:53:49
|
The patch titled coverity: fix fbsysfs null pointer check has been added to the -mm tree. Its filename is coverity-fbsysfs-fix-null-pointer-check.patch Patches currently in -mm which might be from kam...@be... are coverity-fbsysfs-fix-null-pointer-check.patch From: "KAMBAROV, ZAUR" <kam...@be...> Correctly test for a null pointer before going and dereferencing it. This defect was found automatically by Coverity Prevent, a static analysis tool. Signed-off-by: Zaur Kambarov <zka...@co...> Cc: <lin...@li...> Signed-off-by: Andrew Morton <ak...@os...> --- drivers/video/fbsysfs.c | 2 +- 1 files changed, 1 insertion(+), 1 deletion(-) diff -puN drivers/video/fbsysfs.c~coverity-fbsysfs-fix-null-pointer-check drivers/video/fbsysfs.c --- devel/drivers/video/fbsysfs.c~coverity-fbsysfs-fix-null-pointer-check 2005-06-30 22:52:31.000000000 -0700 +++ devel-akpm/drivers/video/fbsysfs.c 2005-06-30 22:52:31.000000000 -0700 @@ -256,7 +256,7 @@ static ssize_t show_cmap(struct class_de unsigned int offset = 0, i; if (!fb_info->cmap.red || !fb_info->cmap.blue || - fb_info->cmap.green || fb_info->cmap.transp) + !fb_info->cmap.green || !fb_info->cmap.transp) return -EINVAL; for (i = 0; i < fb_info->cmap.len; i++) { _ |
From: James S. <jsi...@ww...> - 2005-07-01 23:53:31
|
Good find. I noticed a problem with transp. The transp field might or might not be there. That needs fixing as well. On Thu, 30 Jun 2005 ak...@os... wrote: > > The patch titled > > coverity: fix fbsysfs null pointer check > > has been added to the -mm tree. Its filename is > > coverity-fbsysfs-fix-null-pointer-check.patch > > Patches currently in -mm which might be from kam...@be... are > > coverity-fbsysfs-fix-null-pointer-check.patch > > > > From: "KAMBAROV, ZAUR" <kam...@be...> > > Correctly test for a null pointer before going and dereferencing it. > > This defect was found automatically by Coverity Prevent, a static analysis > tool. > > Signed-off-by: Zaur Kambarov <zka...@co...> > Cc: <lin...@li...> > Signed-off-by: Andrew Morton <ak...@os...> > --- > > drivers/video/fbsysfs.c | 2 +- > 1 files changed, 1 insertion(+), 1 deletion(-) > > diff -puN drivers/video/fbsysfs.c~coverity-fbsysfs-fix-null-pointer-check drivers/video/fbsysfs.c > --- devel/drivers/video/fbsysfs.c~coverity-fbsysfs-fix-null-pointer-check 2005-06-30 22:52:31.000000000 -0700 > +++ devel-akpm/drivers/video/fbsysfs.c 2005-06-30 22:52:31.000000000 -0700 > @@ -256,7 +256,7 @@ static ssize_t show_cmap(struct class_de > unsigned int offset = 0, i; > > if (!fb_info->cmap.red || !fb_info->cmap.blue || > - fb_info->cmap.green || fb_info->cmap.transp) > + !fb_info->cmap.green || !fb_info->cmap.transp) > return -EINVAL; > > for (i = 0; i < fb_info->cmap.len; i++) { > _ > > > ------------------------------------------------------- > SF.Net email is sponsored by: Discover Easy Linux Migration Strategies > from IBM. Find simple to follow Roadmaps, straightforward articles, > informative Webcasts and more! Get everything you need to get up to > speed, fast. http://ads.osdn.com/?ad_id=7477&alloc_id=16492&op=click > _______________________________________________ > Linux-fbdev-devel mailing list > Lin...@li... > https://lists.sourceforge.net/lists/listinfo/linux-fbdev-devel > |