On Wed, 18 Jul 2001, Andreas Hundt wrote:
> hi,
>
> I have a new patch for aty128fb in 2.4.6. It has all of benh's fixes + mine.
> Everyone should be happy with it now. It has both 15 and 16bpp support, does not
> break the gamma ramp feature, etc. Maybe this should be merged in the mainstream
> kernel.
This part does not make much sense:
@@ -1363,7 +1484,7 @@
aty128_encode_var(var, &par, info);
- if ((var->activate & FB_ACTIVATE_MASK) != FB_ACTIVATE_NOW)
+ if ((var->activate & FB_ACTIVATE_MASK) == FB_ACTIVATE_TEST)
return 0;
oldxres = display->var.xres;
You call encode_var which sets var->activate to 0, and then test it, so
the test always fails, and FB_ACTIVATE_TEST behaviour is broken both
before and after your patch.
--
Matan Ziv-Av. ma...@sv...
|