Re: [f2fs-dev] [PATCH V3 5/6] f2fs: ignore discard return value

[Chao Yu <ch...@ke...>]

On 11/25/2025 7:48 AM, Chaitanya Kulkarni wrote:
> __blkdev_issue_discard() always returns 0, making the error assignment
> in __submit_discard_cmd() dead code.
> 
> Initialize err to 0 and remove the error assignment from the
> __blkdev_issue_discard() call to err. Move fault injection code into
> already present if branch where err is set to -EIO.
> 
> This preserves the fault injection behavior while removing dead error
> handling.
> 
> Reviewed-by: Martin K. Petersen <mar...@or...>
> Reviewed-by: Johannes Thumshirn <joh...@wd...>
> Reviewed-by: Christoph Hellwig <hc...@ls...>
> Signed-off-by: Chaitanya Kulkarni <cku...@gm...>

Reviewed-by: Chao Yu <ch...@ke...>

Thanks,