[Linux-decnet-user] 'make rpm' fails

[Hartmut B. <Har...@co...>]

Oracle Linux Server release 7.1
# cat /etc/redhat-release
Red Hat Enterprise Linux Server release 7.1 (Maipo)
# uname -a
Linux oel.wherever.net 3.8.13-118.el7uek.x86_64 #2 SMP Tue Nov 10
18:25:35 PST 2015 x86_64 x86_64 x86_64 GNU/Linux
# cc -v
Using built-in specs.
COLLECT_GCC=cc
COLLECT_LTO_WRAPPER=/usr/libexec/gcc/x86_64-redhat-linux/4.8.3/lto-wrapper
Target: x86_64-redhat-linux
Configured with: ../configure --prefix=/usr --mandir=/usr/share/man
--infodir=/usr/share/info
--with-bugurl=http://bugzilla.redhat.com/bugzilla --enable-bootstrap
--enable-shared --enable-threads=posix --enable-checking=release
--with-system-zlib --enable-__cxa_atexit --disable-libunwind-exceptions
--enable-gnu-unique-object --enable-linker-build-id
--with-linker-hash-style=gnu
--enable-languages=c,c++,objc,obj-c++,java,fortran,ada,go,lto
--enable-plugin --enable-initfini-array --disable-libgcj
--with-isl=/builddir/build/BUILD/gcc-4.8.3-20140911/obj-x86_64-redhat-linux/isl-install
--with-cloog=/builddir/build/BUILD/gcc-4.8.3-20140911/obj-x86_64-redhat-linux/cloog-install
--enable-gnu-indirect-function --with-tune=generic --with-arch_32=x86-64
--build=x86_64-redhat-linux
Thread model: posix
gcc version 4.8.3 20140911 (Red Hat 4.8.3-9) (GCC)
#

The DNprogs build with a couple of warnings, for example

connection.cc:932:26: warning: narrowing conversion of ‘(((int)crc) &
255)’ from ‘int’ to ‘char’ inside { } is ill-formed in
C++11 [-Wnarrowing]
connection.cc:932:36: warning: narrowing conversion of ‘(((int)crc) >>
8)’ from ‘int’ to ‘char’ inside { } is ill-formed in
C++11 [-Wnarrowing]
connection.cc:932:26: warning: narrowing conversion of ‘(((int)crc) &
255)’ from ‘int’ to ‘char’ inside { } is ill-formed in
C++11 [-Wnarrowing]
connection.cc:932:36: warning: narrowing conversion of ‘(((int)crc) >>
8)’ from ‘int’ to ‘char’ inside { } is ill-formed in
C++11 [-Wnarrowing]
readwrite.cc:98:16: warning: deprecated conversion from string constant
to ‘char*’ [-Wwrite-strings]
readwrite.cc:98:16: warning: deprecated conversion from string constant
to ‘char*’ [-Wwrite-strings]
...

I didn't try to set any language mode with any -std option. Maybe that
fixes at least C++11 warnings.

Anyway, the results seem to work. However I can't build an RPM (binaries
are what I need).
'make rpm' fails with

install: failed to access
‘/root/decnet-dnprogs/dnprogs-2.61-orig/rpmbuild/etc/rc.d/init.d/decnet’: Not
a directory
make[2]: *** [install] Error 1
make[2]: Leaving directory /root/decnet-dnprogs/dnprogs-2.61-orig/scripts'
make[1]: *** [install] Error 2
make[1]: Leaving directory /root/decnet-dnprogs/dnprogs-2.61-orig'
make: *** [rpm] Error 2

That's only the first of several failures. I can work/hack around them
by changing ./dnetd/Makefile, ./Makefile, ./rpm.spec and
finally manuall doing a rpmbuild. But I'm not an rpm expert. So maybe
someone wants to have a look at this.
hartmut@becker--6735b:~$ jed dnprogs.txt
hartmut@becker--6735b:~$ cat dnprogs.txt
# cat /etc/oracle-release
Oracle Linux Server release 7.1
# cat /etc/redhat-release
Red Hat Enterprise Linux Server release 7.1 (Maipo)
# uname -a
Linux oel.wherever.net 3.8.13-118.el7uek.x86_64 #2 SMP Tue Nov 10
18:25:35 PST 2015 x86_64 x86_64 x86_64 GNU/Linux
# cc -v
Using built-in specs.
COLLECT_GCC=cc
COLLECT_LTO_WRAPPER=/usr/libexec/gcc/x86_64-redhat-linux/4.8.3/lto-wrapper
Target: x86_64-redhat-linux
Configured with: ../configure --prefix=/usr --mandir=/usr/share/man
--infodir=/usr/share/info
--with-bugurl=http://bugzilla.redhat.com/bugzilla --enable-bootstrap
--enable-shared --enable-threads=posix --enable-checking=release
--with-system-zlib --enable-__cxa_atexit --disable-libunwind-exceptions
--enable-gnu-unique-object --enable-linker-build-id
--with-linker-hash-style=gnu
--enable-languages=c,c++,objc,obj-c++,java,fortran,ada,go,lto
--enable-plugin --enable-initfini-array --disable-libgcj
--with-isl=/builddir/build/BUILD/gcc-4.8.3-20140911/obj-x86_64-redhat-linux/isl-install
--with-cloog=/builddir/build/BUILD/gcc-4.8.3-20140911/obj-x86_64-redhat-linux/cloog-install
--enable-gnu-indirect-function --with-tune=generic --with-arch_32=x86-64
--build=x86_64-redhat-linux
Thread model: posix
gcc version 4.8.3 20140911 (Red Hat 4.8.3-9) (GCC)
#

The dnprogs-2.61 build with a couple of warnings, for example

connection.cc:932:26: warning: narrowing conversion of ‘(((int)crc) &
255)’ from ‘int’ to ‘char’ inside { } is ill-formed in
C++11 [-Wnarrowing]
connection.cc:932:36: warning: narrowing conversion of ‘(((int)crc) >>
8)’ from ‘int’ to ‘char’ inside { } is ill-formed in
C++11 [-Wnarrowing]
connection.cc:932:26: warning: narrowing conversion of ‘(((int)crc) &
255)’ from ‘int’ to ‘char’ inside { } is ill-formed in
C++11 [-Wnarrowing]
connection.cc:932:36: warning: narrowing conversion of ‘(((int)crc) >>
8)’ from ‘int’ to ‘char’ inside { } is ill-formed in
C++11 [-Wnarrowing]
readwrite.cc:98:16: warning: deprecated conversion from string constant
to ‘char*’ [-Wwrite-strings]
readwrite.cc:98:16: warning: deprecated conversion from string constant
to ‘char*’ [-Wwrite-strings]
...

I didn't try to set any language mode with any -std option. Maybe that
fixes at least C++11 warnings.

Anyway, the results seem to work. However I can't build an RPM (binaries
are what I need).
'make rpm' fails with

install: failed to access
‘/root/decnet-dnprogs/dnprogs-2.61-orig/rpmbuild/etc/rc.d/init.d/decnet’: Not
a directory
make[2]: *** [install] Error 1
make[2]: Leaving directory /root/decnet-dnprogs/dnprogs-2.61-orig/scripts'
make[1]: *** [install] Error 2
make[1]: Leaving directory /root/decnet-dnprogs/dnprogs-2.61-orig'
make: *** [rpm] Error 2

That's only the first of several failures. I can work/hack around them
by changing ./dnetd/Makefile, ./Makefile, ./rpm.spec and
finally manuall doing a rpmbuild. But I'm not an rpm expert. So maybe
someone wants to have a look at this.