Re: [Linux-decnet-user] [PATCH] decnet: remove macro-local declarations

[David M. <da...@da...>]

From: Julia Lawall <Jul...@li...>
Date: Thu,  5 Nov 2015 11:18:16 +0100

> Move the variable declarations from the for_nexthops macro to the
> surrounding context, so that it is clear where these variables are
> declared.  This also makes it possible to remove the endfor_nexthops macro.
> 
> This change adds new arguments to the macro for_nexthops.  They are ordered
> such that a pointer to the referenced object comes first, the index in the
> list comes next, and the list itself comes last, roughly in analogy with
> the list_for_each macros.
> 
> Signed-off-by: Julia Lawall <Jul...@li...>
> 
> ---
> 
> This patch takes care of a single file, where the macros are defined
> locally.  If the basic transformation looks OK, I will change the other
> files that either likewise define their own macros or use the macros in
> net/mpls/internal.h.  The potentially affected files are:
 ...

This looks fine to me.

Please resubmit this when net-next opens back up, which should be
shortly after -rc1.

Thanks.