[Linux-decnet-user] Re: DECnet routing fixes etc.

[David S. M. <da...@re...>]

Stephen, I would apply this but there is a huge error you must
correct first.

try_module_get(THIS_MODULE) has zero meaning, it is bug anytime
it is coded.  In fact I may ask Rusty to BUG() check for this.
Consider the case that the module count is currently zero and
on another cpu we are currently unloading the decnet module.
This will explode, in short order.

I know you want to get rid of the MOD_{INC,DEC}_USE_COUNT deprecation
warnings, however don't do so by introducing new bugs.

How to fix this properly?  Good question :-)  Arnaldo de Melo is
working on adding a struct module pointer to proto_ops so that this
can be handled cleanly, ie. sock_create() does a try_module_get()
on proto_ops->owner before calling into the AF specific code.

So until Arnaldo puts that infrastructure in, please just delete
the MOD_{INC,DEC}_USE_COUNT bits from your patch and I'll apply
it to 2.5.x ok?

Thanks.