Re: [Linux-decnet-user] RE: Help decnet/XFree Problem

[Patrick C. <pa...@ty...>]

On Fri, Jul 26, 2002 at 04:53:16PM +0100, Patrick Caulfield wrote:
> 
> I think I know what's happening but I'm not sure how to stop it.  The X server
> has a SIGALRM timer that goes off every so often. If it's reading from the
> DECnet socket when that happens DECnet, returns -ERESTARTSYS which the Xserver
> interprets as an error and closes the socket.
> 
> I've tried changing this to -EINTR and it doesn't seem to make much of a
> difference. Oddly, if I strace the Xserver running ico from a Unix box it never
> seems to return -EINTR, only data and -EAGAIN. If you're feeling brave you might
> like to change the ERESTARTSYS to an EAGAIN and see what happens ;-)
> 

Well, I tried it and it works. It's almost certainly wrong so there's not much
chance of that patch getting into the kernel but I've had an ico running from a
fairly fast Alpha down a 100Meg ethernet for some time now and it's fine.

More investigation will follow when I get back. In the meantime the workaround
patch is:

--- net/decnet/af_decnet.c.orig Fri Jul 26 18:09:54 2002
+++ net/decnet/af_decnet.c      Fri Jul 26 18:11:31 2002
@@ -1771,7 +1771,7 @@
                        goto out;

                if (signal_pending(current)) {
-                       rv = -ERESTARTSYS;
+                       rv = -EAGAIN;
                        goto out;
                }



patrick