RE: [Linux-decnet-user] Closing DECNET connections

[Lhota R. <rl...@co...>]

Hi,

thank you for the patch. I appied it, recompilled the kernel, but
unfortunatelly, it doesn't work for me. During dnping execution, the
program tries to connect to the destination vax machine and sometimes
this connect takes very long time or freezes at all and then dnping ends
with timeout and the RUN IMMED connection still remains forever.

Robert

> -----Original Message-----
> From: Patrick Caulfield [mailto:pa...@ty...]
> Sent: Thursday, April 18, 2002 4:59 PM
> To: Lin...@li...
> Subject: Re: [Linux-decnet-user] Closing DECNET connections
>=20
>=20
> On Thu, Apr 18, 2002 at 02:51:52PM +0100, Steven Whitehouse wrote:
> > Hi,
> >=20
> > >=20
> > Patrick says that it happens in 2.4.0, so you could try=20
> something older than
> > that, but I certainly wouldn't recommend using it for=20
> production at all. It
> > seems that there is a real bug here, but I'm unfortunately=20
> rather short of
> > time to investigate it right now.
> >=20
> > I wonder if its actually a DECnet system call that gets=20
> interrupted in
> > such a way as to get a reference count wrong during the=20
> exit code path
> > and thus the socket never gets destroyed.
> >=20
> > Its odd because when the process exits, the release method=20
> should be called
> > for the socket and that has all the socket shut down code=20
> in it so whatever
> > happens it should work, though I know it doesn't,
> >=20
>=20
> Here's a patch which works for me:
>=20
> $ diff -u net/decnet/af_decnet.c.orig net/decnet/af_decnet.c
> --- net/decnet/af_decnet.c.orig Thu Apr 18 15:46:11 2002
> +++ net/decnet/af_decnet.c      Thu Apr 18 15:46:34 2002
> @@ -747,10 +747,10 @@
>         struct sock *sk =3D sock->sk;
>=20
>         if (sk) {
> -               sock_orphan(sk);
>                 sock_hold(sk);
>                 lock_sock(sk);
>                 dn_destroy_sock(sk);
> +               sock_orphan(sk);
>                 release_sock(sk);
>                 sock_put(sk);
>         }
>=20
> I'll forward it to Dave Miller for inclusion in the stock kernel.
>=20
> patrick
>=20
>=20
> _______________________________________________
> Linux-decnet-user mailing list
> Lin...@li...
> https://lists.sourceforge.net/lists/listinfo/linux-decnet-user
>=20